Update goal response callback signature #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The signature changed in ros2/rclcpp#1311 Also remove related dead code. Signed-off-by: Jacob Perron <[email protected]>
jacobperron
force-pushed
the
jacob/actions_refactor
branch
from
ff4d520 to
1845447
Compare
Contributor
Author
jacobperron
added a commit
to ros2/ros2
that referenced
this pull request
Sep 19, 2020
Connects to ros/ros_tutorials#100. Signed-off-by: Jacob Perron <[email protected]>
Member
|
Please also update the branch in the gbp repository. |
Contributor
Author
dirk-thomas
approved these changes
Sep 19, 2020
Member
dirk-thomas
left a comment
dirk-thomas
left a comment
There was a problem hiding this comment.
👍 once PR CI is setup, ran and passed.
jacobperron
added a commit
to ros2/ros2
that referenced
this pull request
Sep 21, 2020
Connects to ros/ros_tutorials#100. Signed-off-by: Jacob Perron <[email protected]>
ivanpauno
approved these changes
Sep 21, 2020
eholum
pushed a commit
to eholum/space-ros
that referenced
this pull request
Jun 26, 2024
Connects to ros/ros_tutorials#100. Signed-off-by: Jacob Perron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signature changed in ros2/rclcpp#1311
Also remove related dead code.
Since this is not compatible with Foxy, I've created and targeted a new
galactic-develbranch.TODO: