Upgrade to Node.js v20

.github/workflows/test.yml

@@ -16,17 +16,17 @@ jobs:
   test_setup_ros:
     runs-on: ubuntu-latest
     container:
-      image: ubuntu:focal
+      image: ubuntu:jammy
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
       with:
         path: '.'
-    - uses: actions/setup-node@v3.5.1
+    - uses: actions/setup-node@v4
       with:
-        node-version: '12.x'
+        node-version: '20.x'
     - run: .github/workflows/build-and-test.sh
-    - uses: ros-tooling/setup-ros@v0.6
-    - uses: actions/checkout@v3
+    - uses: ros-tooling/setup-ros@v0.7
+    - uses: actions/checkout@v4
       with:
         repository: ament/ament_lint
         ref: humble
@@ -54,17 +54,16 @@ jobs:
   test_setup_ros_docker:
     runs-on: ubuntu-latest
     container:
-      image: rostooling/setup-ros-docker:ubuntu-focal-latest
-      options: -u root  # setup-node requires root access
+      image: rostooling/setup-ros-docker:ubuntu-jammy-latest
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
       with:
         path: '.'
-    - uses: actions/setup-node@v3.5.1
+    - uses: actions/setup-node@v4
       with:
-        node-version: '12.x'
+        node-version: '20.x'
     - run: .github/workflows/build-and-test.sh
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
       with:
         repository: ament/ament_lint
         ref: humble

DEVELOPING.md

@@ -1,5 +1,11 @@
 # Developing action-ros-lint
 
+## Prerequisites
+
+Install [Node.js](https://nodejs.org/en/download/).
+
+We are currently using Node.js v20.
+
 ## Build and test
 
 ```

README.md

@@ -22,9 +22,9 @@ See [action.yml](action.yml)
 
 ```yaml
 container:
-  image: ubuntu:bionic
+  image: ubuntu:noble
 steps:
-- uses: actions/checkout@v2
+- uses: actions/checkout@v4
 - uses: ros-tooling/setup-ros@master
 - uses: ros-tooling/action-ros-lint@master
   with:
@@ -39,13 +39,13 @@ jobs:
   ament_lint:
     runs-on: ubuntu-latest
     container:
-      image: ubuntu:bionic
+      image: ubuntu:noble
     strategy:
       fail-fast: false
       matrix:
           linter: [copyright, flake8, mypy, pep257, pep8, xmllint]
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v4
     - uses: ros-tooling/setup-ros@master
     - uses: ros-tooling/action-ros-lint@master
       with:
@@ -65,14 +65,13 @@ jobs:
   ament_lint:
     runs-on: ubuntu-latest
     container:
-      image: rostooling/setup-ros-docker:ubuntu-bionic-ros-eloquent-ros-base-latest
-      options: -u root  # setup-node requires root access
+      image: ghcr.io/ros-tooling/setup-ros-docker/setup-ros-docker-ubuntu-noble-ros-jazzy-ros-base
     strategy:
       fail-fast: false
       matrix:
           linter: [copyright, flake8, mypy, pep257, pep8, xmllint]
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v4
     - uses: ros-tooling/action-ros-lint@master
       with:
         linter: ${{ matrix.linter }}

__test__/main.test.ts

@@ -1,7 +1,11 @@
-import * as action_ros_lint from "../src/action-ros-lint";
-
-describe('Run workflow', () => {
-    it('run workflow', async () => {
-        await expect(action_ros_lint.run()).resolves.not.toThrow();
-    })
-})
+import * as core from "@actions/core";
+import * as action_ros_lint from "../src/action-ros-lint";
+
+describe('Run workflow', () => {
+    it('run workflow', async () => {
+        await expect(action_ros_lint.run()).resolves.not.toThrow();
+        // Check and reset process exit code, which is set when core.setFailed() is called
+        expect(process.exitCode).toBe(core.ExitCode.Failure);
+        process.exitCode = core.ExitCode.Success;
+    })
+})

action.yml

@@ -26,5 +26,5 @@ inputs:
     description: Linters will look for packages in this colcon workspace
     required: false
 runs:
-  using: 'node12'
+  using: 'node20'
   main: 'dist/index.js'