Skip to content

Conversation

@mini-1235
Copy link
Contributor


Basic Info

Info Please fill out this column
Ticket(s) this addresses #4907
Primary OS tested on Ubuntu
Robotic platform tested on Tb4
Does this PR contain AI generated software? No
Was this PR description generated by AI software? Out of respect for maintainers, AI for human-to-human communications are banned

Description of contribution in a few bullet points

  • Add post_set_params_handler_ in DWB
  • Move the params_handler to the Activate() stage

Description of documentation updates required from your changes

Description of how this change was tested


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists
  • Should this be backported to current distributions? If so, tag with backport-*.

@SteveMacenski
Copy link
Member

CI is reporting a linting error

Signed-off-by: mini-1235 <[email protected]>
@mini-1235
Copy link
Contributor Author

mini-1235 commented Oct 23, 2025

CI is reporting a linting error

That part is formatted by uncrustify, if I follow the cpplint's suggestion, then uncrustify will not pass. I will just add a //NOLINT there

@mergify
Copy link
Contributor

mergify bot commented Oct 23, 2025

@mini-1235, your PR has failed to build. Please check CI outputs and resolve issues.
You may need to rebase or pull in main due to API changes (or your contribution genuinely fails).

@SteveMacenski SteveMacenski merged commit 976fbeb into ros-navigation:main Oct 23, 2025
14 of 15 checks passed
@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
...dwb_core/include/dwb_core/trajectory_generator.hpp 100.00% <ø> (ø)
..._dwb_controller/dwb_core/src/dwb_local_planner.cpp 81.60% <100.00%> (+0.14%) ⬆️
...ugins/include/dwb_plugins/kinematic_parameters.hpp 100.00% <ø> (ø)
...ns/include/dwb_plugins/standard_traj_generator.hpp 100.00% <ø> (ø)
...ontroller/dwb_plugins/src/kinematic_parameters.cpp 100.00% <100.00%> (ø)
...roller/dwb_plugins/src/standard_traj_generator.cpp 97.82% <100.00%> (+0.09%) ⬆️

... and 13 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants