Skip to content

Commit 848f2b0

Browse files
Nils-ChristianIsekeNils-ChristianIseke
authored
Pre-Commit (#4915)
* Add pre-commit Signed-off-by: Nils-ChristianIseke <[email protected]> * Add codespell workflow Signed-off-by: Nils-ChristianIseke <[email protected]> * Codespell write_changes=false. As otherwise CI does not fail. Signed-off-by: Nils-ChristianIseke <[email protected]> * Configure isort Signed-off-by: Nils-ChristianIseke <[email protected]> * add precommit Signed-off-by: Nils-ChristianIseke <[email protected]> * Introducing some issues. Signed-off-by: Nils-ChristianIseke <[email protected]> * Revert "Introducing some issues." This reverts commit 5377b65. Signed-off-by: Nils-ChristianIseke <[email protected]> * Removing pre-commit workflow. Signed-off-by: Nils-ChristianIseke <[email protected]> * Fix formatting error Signed-off-by: Nils-ChristianIseke <[email protected]> * Merge remote-tracking branch 'origin/main' into precommit Signed-off-by: Nils-ChristianIseke <[email protected]> * Change v31 to v32 Signed-off-by: Nils-ChristianIseke <[email protected]> * Revert "Merge remote-tracking branch 'origin/main' into precommit" This reverts commit 8a7ca39. Signed-off-by: Nils-ChristianIseke <[email protected]> * Rm submodule Signed-off-by: Nils-ChristianIseke <[email protected]> * pre-commit run --all after merge Signed-off-by: Nils-ChristianIseke <[email protected]> --------- Signed-off-by: Nils-ChristianIseke <[email protected]>
1 parent 018448f commit 848f2b0

File tree

174 files changed

+521
-725
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

174 files changed

+521
-725
lines changed

‎.devcontainer/caddy/srv/assets/foxglove/nav2_layout.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -460,4 +460,4 @@
460460
"direction": "row",
461461
"splitPercentage": 74.87855655794587
462462
}
463-
}
463+
}

‎.devcontainer/caddy/srv/nav2/github-markdown.css‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1099,4 +1099,4 @@
10991099

11001100
.markdown-body ::-webkit-calendar-picker-indicator {
11011101
filter: invert(50%);
1102-
}
1102+
}

‎.github/mergify.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ pull_request_rules:
77
backport:
88
branches:
99
- jazzy
10-
10+
1111
- name: backport to iron at reviewers discretion
1212
conditions:
1313
- base=main
@@ -16,7 +16,7 @@ pull_request_rules:
1616
backport:
1717
branches:
1818
- iron
19-
19+
2020
- name: backport to humble at reviewers discretion
2121
conditions:
2222
- base=main

‎.github/workflows/codespell.yml‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
name: Codespell
2+
on:
3+
pull_request:
4+
5+
jobs:
6+
codespell:
7+
name: Run codespell
8+
runs-on: ubuntu-latest
9+
steps:
10+
- uses: actions/checkout@v4
11+
- name: Install codespell
12+
run: pip install codespell
13+
- name: Run codespell
14+
run: codespell --toml ./tools/pyproject.toml

‎.gitignore‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,4 +69,3 @@ Session.vim
6969

7070
# Vim Temporary
7171
.netrwhist
72-

‎.pre-commit-config.yaml‎

Lines changed: 97 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,97 @@
1+
2+
# To use:
3+
#
4+
# pre-commit run -a
5+
#
6+
# Or:
7+
#
8+
# pre-commit install # (runs every time you commit in git)
9+
#
10+
# To update this file:
11+
#
12+
# pre-commit autoupdate
13+
#
14+
# See https://github.com/pre-commit/pre-commit
15+
exclude: ".pgm$|.svg$"
16+
repos:
17+
- repo: https://github.com/pre-commit/pre-commit-hooks
18+
rev: v5.0.0
19+
hooks:
20+
- id: check-added-large-files
21+
- id: check-ast
22+
- id: check-case-conflict
23+
- id: check-merge-conflict
24+
- id: check-symlinks
25+
- id: check-xml
26+
- id: check-yaml
27+
args: ["--allow-multiple-documents"]
28+
- id: debug-statements
29+
- id: end-of-file-fixer
30+
- id: forbid-submodules
31+
- id: mixed-line-ending
32+
- id: trailing-whitespace
33+
exclude_types: [rst]
34+
- id: fix-byte-order-marker
35+
- repo: https://github.com/pycqa/isort
36+
rev: 6.0.1
37+
hooks:
38+
- id: isort
39+
args: ["tools/pyproject.toml"]
40+
name: isort (python)
41+
42+
- repo: https://github.com/codespell-project/codespell
43+
rev: v2.4.1
44+
hooks:
45+
- id: codespell
46+
additional_dependencies:
47+
- tomli
48+
args:
49+
[--toml=./tools/pyproject.toml]
50+
- repo: https://github.com/python-jsonschema/check-jsonschema
51+
rev: 0.31.1
52+
hooks:
53+
- id: check-github-workflows
54+
args: ["--verbose"]
55+
- id: check-github-actions
56+
args: ["--verbose"]
57+
- id: check-dependabot
58+
args: ["--verbose"]
59+
- repo: local
60+
hooks:
61+
- id: ament_lint_cmake
62+
name: ament_lint_cmake
63+
description: Check CMake code style using cmakelint.
64+
language: system
65+
types: [cmake]
66+
entry: ament_lint_cmake
67+
- id: ament_cpplint
68+
name: ament_cpplint
69+
description: Code style checking using cpplint.
70+
language: system
71+
types: [c++]
72+
entry: ament_cpplint
73+
- id: ament_uncrustify
74+
name: ament_uncrustify
75+
description: Code style checking using uncrustify.
76+
language: system
77+
types: [c++]
78+
args: ["--reformat"]
79+
entry: ament_uncrustify
80+
- id: ament_xmllint
81+
name: ament_xmllint
82+
description: Check XML markup using xmllint.
83+
language: system
84+
types: [xml]
85+
entry: ament_xmllint
86+
- id: ament_flake8
87+
name: ament_flake8
88+
description: Check Python code style using flake8.
89+
language: system
90+
types: [python]
91+
entry: ament_flake8
92+
- id: ament_pep257
93+
name: ament_pep257
94+
description: Check Python code style using pep257.
95+
language: system
96+
types: [python]
97+
entry: ament_pep257

‎Dockerfile‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ RUN mkdir -p $ROOT_SRV
168168

169169
# install demo dependencies
170170
RUN apt-get update && apt-get install -y \
171-
ros-$ROS_DISTRO-rviz2
171+
ros-$ROS_DISTRO-rviz2
172172

173173
# install gzweb dependacies
174174
RUN apt-get install -y --no-install-recommends \

‎README.md‎

Lines changed: 39 additions & 39 deletions
Large diffs are not rendered by default.

‎doc/development/codespaces.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,4 +20,4 @@ TODO: gazebo example with gzweb
2020

2121
# References
2222

23-
TODO: links to more info
23+
TODO: links to more info

‎doc/requirements/_template_requirement.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ The \<navigation system> should be able to \<shall> \<do something>
33

44
## More details
55
- Why is this needed?
6-
- What is the expected user interaction?
6+
- What is the expected user interaction?
77
- What use case does this map to?
88
- Are there any non-functional requirements (build system, tools, performance, etc)
99

0 commit comments

Comments
 (0)