Skip to content

Commit 09786ee

Browse files
MygaoKyungsik Park
authored andcommitted
Move lines for pre-computation to outside a loop
Signed-off-by: Kyungsik Park <[email protected]>
1 parent db974ea commit 09786ee

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

nav2_amcl/src/sensors/laser/likelihood_field_model.cpp

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,17 @@ LikelihoodFieldModel::sensorFunction(LaserData * data, pf_sample_set_t * set)
5353

5454
self = reinterpret_cast<LikelihoodFieldModel *>(data->laser);
5555

56+
// Pre-compute a couple of things
57+
double z_hit_denom = 2 * self->sigma_hit_ * self->sigma_hit_;
58+
double z_rand_mult = 1.0 / data->range_max;
59+
60+
step = (data->range_count - 1) / (self->max_beams_ - 1);
61+
62+
// Step size must be at least 1
63+
if (step < 1) {
64+
step = 1;
65+
}
66+
5667
total_weight = 0.0;
5768

5869
// Compute the sample weights
@@ -65,17 +76,6 @@ LikelihoodFieldModel::sensorFunction(LaserData * data, pf_sample_set_t * set)
6576

6677
p = 1.0;
6778

68-
// Pre-compute a couple of things
69-
double z_hit_denom = 2 * self->sigma_hit_ * self->sigma_hit_;
70-
double z_rand_mult = 1.0 / data->range_max;
71-
72-
step = (data->range_count - 1) / (self->max_beams_ - 1);
73-
74-
// Step size must be at least 1
75-
if (step < 1) {
76-
step = 1;
77-
}
78-
7979
for (i = 0; i < data->range_count; i += step) {
8080
obs_range = data->ranges[i][0];
8181
obs_bearing = data->ranges[i][1];

0 commit comments

Comments
 (0)