Skip to content

Use get_lifecycle_id instead of get_lifecycle_state#2053

Merged
christophfroehlich merged 2 commits intomasterfrom
change_to_get_lifecycle_id
Dec 7, 2025
Merged

Use get_lifecycle_id instead of get_lifecycle_state#2053
christophfroehlich merged 2 commits intomasterfrom
change_to_get_lifecycle_id

Conversation

@saikishor
Copy link
Copy Markdown
Member

@saikishor saikishor commented Dec 7, 2025

Use the new API instead of get_lifecycle_state

@saikishor saikishor added backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted. labels Dec 7, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 7, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.94%. Comparing base (79f917e) to head (549fd10).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...ory_controller/src/joint_trajectory_controller.cpp 0.00% 1 Missing and 1 partial ⚠️
...llers/src/motion_primitives_forward_controller.cpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2053      +/-   ##
==========================================
- Coverage   84.94%   84.94%   -0.01%     
==========================================
  Files         148      148              
  Lines       14425    14424       -1     
  Branches     1235     1236       +1     
==========================================
- Hits        12253    12252       -1     
  Misses       1742     1742              
  Partials      430      430
Flag Coverage Δ
unittests 84.94% <25.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ntroller/test/test_trajectory_controller_utils.hpp 84.79% <100.00%> (-0.05%) ⬇️
...llers/src/motion_primitives_forward_controller.cpp 32.25% <0.00%> (ø)
...ory_controller/src/joint_trajectory_controller.cpp 83.88% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

christophfroehlich
christophfroehlich previously approved these changes Dec 7, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@christophfroehlich christophfroehlich merged commit 4a8192a into master Dec 7, 2025
12 of 17 checks passed
@christophfroehlich christophfroehlich deleted the change_to_get_lifecycle_id branch December 7, 2025 15:31
mergify Bot pushed a commit that referenced this pull request Dec 7, 2025
@saikishor @mergify
Use get_lifecycle_id instead of get_lifecycle_state (#2053)
813ce23 
(cherry picked from commit 4a8192a)
mergify Bot pushed a commit that referenced this pull request Dec 7, 2025
@saikishor @mergify
Use get_lifecycle_id instead of get_lifecycle_state (#2053)
30b56b6 
(cherry picked from commit 4a8192a)

# Conflicts:
#	motion_primitives_controllers/src/motion_primitives_forward_controller.cpp
This was referenced Dec 7, 2025
Merged
Merged
christophfroehlich pushed a commit that referenced this pull request Dec 7, 2025
@mergify
Use get_lifecycle_id instead of get_lifecycle_state (backport #2053) (#…
4a18571 
…2055)
christophfroehlich pushed a commit that referenced this pull request Dec 7, 2025
@mergify
Use get_lifecycle_id instead of get_lifecycle_state (backport #2053) (#…
b99da06 
…2056)
@christophfroehlich
Copy link
Copy Markdown
Member

christophfroehlich commented Feb 22, 2026

@Mergifyio backport mergify/bp/jazzy/pr-1636

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Feb 22, 2026 •
edited
Loading

backport mergify/bp/jazzy/pr-1636

✅ Backports have been created

Details

mergify Bot pushed a commit that referenced this pull request Feb 22, 2026
@saikishor @mergify
Use get_lifecycle_id instead of get_lifecycle_state (#2053)
e987cd3 
(cherry picked from commit 4a8192a)
@mergify mergify Bot mentioned this pull request Feb 22, 2026
Merged
christophfroehlich pushed a commit that referenced this pull request Feb 22, 2026
@mergify @saikishor
Use get_lifecycle_id instead of get_lifecycle_state (backport #2053) (#…
eaafaed 
…2182)

Co-authored-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
greencookie-afk pushed a commit to greencookie-afk/ros2_controllers that referenced this pull request Apr 24, 2026
@saikishor
Use get_lifecycle_id instead of get_lifecycle_state (ros-controls#2053)
c09c2b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christophfroehlich christophfroehlich christophfroehlich approved these changes

@arne48 arne48 Awaiting requested review from arne48

@bmagyar bmagyar Awaiting requested review from bmagyar

@MarqRazz MarqRazz Awaiting requested review from MarqRazz

@moriarty moriarty Awaiting requested review from moriarty

@xguay xguay Awaiting requested review from xguay

Assignees

No one assigned

Labels

backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@saikishor @christophfroehlich