-
Notifications
You must be signed in to change notification settings - Fork 430
feature: add support for prefixed joint names in JTC #2005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: jazzy
Are you sure you want to change the base?
Conversation
…troller for chainable controllers situation
|
@Demonmasterlqx, all pull requests must be targeted towards the |
|
Sorry for that but I don't have the develop environment for the master branch. |
christophfroehlich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the exact problem with chained controllers, but I'm not sure if fixing every controller is the way to go.
An alternative would be the remap feature from
ros-controls/ros2_control#1667
or a redesign of the chained controllers' interface namings.
|
A full redesign seems like the optimal long-term solution for a future version. However, this PR offers a perfectly viable solution for the current version. Could you please share if there are any existing plans or design specifications for that future implementation? |
|
There is no solution for that yet. I put that on the agenda of the next PMC meeting. |
feature: add support for prefixed joint names in joint_trajectory_controller for chainable controllers situation
Contributions via pull requests are much appreciated. Before sending us a pull request, please ensure that:
To send us a pull request, please:
colcon testandpre-commit run(requires you to install pre-commit bypip3 install pre-commit)