Controller interfaces remapping proposal #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
DasRoteSkelett,
VanshGehlot,
bmagyar,
christophfroehlich,
destogl,
mcbed and
moriarty
christophfroehlich
approved these changes
Jul 26, 2024
Contributor
christophfroehlich
left a comment
christophfroehlich
left a comment
There was a problem hiding this comment.
The proposal looks fine for me, I also think this could be valuable.
I just don't know yet how much complexity this will add to the CM.
Member
Author
@christophfroehlich Thanks for reviewing it. As far as I check in the CM, it is not that complex, look at the initial implementation here: saikishor/ros2_control#5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to propose the controller interfaces remapping to ease the controller design and to allow integration with custom interfaces