Skip to content

Conversation

@christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Jul 26, 2025

Once ros-controls/ros2_controllers#1830 and ros-controls/ros2_controllers#1947 is merged.

Those have been out for at least one release cycle on rolling and kilted.

@christophfroehlich christophfroehlich added the hold hold for any reason, comment in PR label Jul 26, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.26%. Comparing base (ae0f699) to head (825d03c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #371      +/-   ##
==========================================
- Coverage   85.39%   85.26%   -0.14%     
==========================================
  Files          17       17              
  Lines        1445     1391      -54     
  Branches      135      132       -3     
==========================================
- Hits         1234     1186      -48     
+ Misses        122      119       -3     
+ Partials       89       86       -3     
Flag Coverage Δ
unittests 85.26% <ø> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ools/include/realtime_tools/realtime_publisher.hpp 90.24% <ø> (-1.76%) ⬇️
realtime_tools/test/realtime_publisher_tests.cpp 92.30% <ø> (+3.73%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

saikishor
saikishor previously approved these changes Jul 28, 2025
@github-actions
Copy link
Contributor

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions bot added the stale label Sep 11, 2025
@christophfroehlich christophfroehlich added the check-prerelease-downstream Runs the pre-release workflow with 1st level downstream dependencies label Sep 24, 2025
@github-actions github-actions bot removed the stale label Sep 25, 2025
@christophfroehlich christophfroehlich moved this from Kilted to ROS-L in Roadmap / Features Sep 29, 2025
@christophfroehlich christophfroehlich removed the hold hold for any reason, comment in PR label Oct 3, 2025
@christophfroehlich christophfroehlich marked this pull request as ready for review October 3, 2025 22:00
@mergify
Copy link

mergify bot commented Oct 5, 2025

This pull request is in conflict. Could you fix it @christophfroehlich?

@mergify
Copy link

mergify bot commented Oct 5, 2025

This pull request is in conflict. Could you fix it @christophfroehlich?

@christophfroehlich christophfroehlich merged commit c8b85b9 into master Oct 7, 2025
15 of 16 checks passed
@christophfroehlich christophfroehlich deleted the cleanup/deprecations branch October 7, 2025 12:40
@github-project-automation github-project-automation bot moved this from ROS-L to Done in Roadmap / Features Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

check-prerelease-downstream Runs the pre-release workflow with 1st level downstream dependencies

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants