Skip to content

Create a healthy culture #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
adlamas wants to merge 1 commit into
base: ehancement/code-review-best-practices
Choose a base branch
from
Draft

Create a healthy culture #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions code-review/examples/healty_culture.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@

class PeopleService
def getPeople
people = Person.all
Copy link
Author

@adlamas adlamas Sep 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agressive comment

Have you read Ruby's guides for methods namings? Obviously, this is not the way. Also, didn't you see this is not correctly indented? You can't make these errors.


return people
end
end
Copy link
Author

@adlamas adlamas Sep 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct comment

Usually, we use snake case for method naming, so maybe we can adapt it. Also, there was a problem with indentation, perhaps, can we reduce it in one space? What do you think? 🤔
Thanks 😄