Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions bindings/pyroot/cppyy/CPyCppyy/src/Converters.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -2502,7 +2502,7 @@ bool CPyCppyy::InstanceArrayConverter::ToMemory(
}

//___________________________________________________________________________
// CLING WORKAROUND -- classes for STL iterators are completely undefined in that
// Cling WORKAROUND -- classes for STL iterators are completely undefined in that
// they come in a bazillion different guises, so just do whatever
bool CPyCppyy::STLIteratorConverter::SetArg(
PyObject* pyobject, Parameter& para, CallContext* /* ctxt */)
Expand All @@ -2516,7 +2516,7 @@ bool CPyCppyy::STLIteratorConverter::SetArg(
para.fTypeCode = 'V';
return true;
}
// -- END CLING WORKAROUND
// -- END Cling WORKAROUND

//----------------------------------------------------------------------------
bool CPyCppyy::VoidPtrRefConverter::SetArg(
Expand Down Expand Up @@ -3348,12 +3348,12 @@ CPyCppyy::Converter* CPyCppyy::CreateConverter(const std::string& fullType, cdim
}

if (!result) {
// CLING WORKAROUND -- special case for STL iterators
// Cling WORKAROUND -- special case for STL iterators
if (Utility::IsSTLIterator(realType)) {
static STLIteratorConverter c;
result = &c;
} else
// -- CLING WORKAROUND
// -- Cling WORKAROUND
result = selectInstanceCnv(klass, cpd, dims, isConst, control);
}
} else {
Expand Down
4 changes: 2 additions & 2 deletions bindings/pyroot/cppyy/CPyCppyy/src/DeclareConverters.h
Original file line number Diff line number Diff line change
Expand Up @@ -334,13 +334,13 @@ class ComplexDConverter: public InstanceConverter {
};


// CLING WORKAROUND -- classes for STL iterators are completely undefined in that
// Cling WORKAROUND -- classes for STL iterators are completely undefined in that
// they come in a bazillion different guises, so just do whatever
class STLIteratorConverter : public Converter {
public:
bool SetArg(PyObject*, Parameter&, CallContext* = nullptr) override;
};
// -- END CLING WORKAROUND
// -- END Cling WORKAROUND


class VoidPtrRefConverter : public Converter {
Expand Down
2 changes: 1 addition & 1 deletion bindings/pyroot/cppyy/CPyCppyy/src/PyResult.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ CPyCppyy::PyResult::operator double() const
CPyCppyy::PyResult::operator void*() const
{
// Cast python return value to C++ object with dictionary (may fail; note that
// you have to use the void* converter, as CINT will not call any other).
// you have to use the void* converter, as Cling will not call any other).
if (fPyObject == Py_None)
return nullptr;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2417,12 +2417,12 @@ intptr_t Cppyy::GetDatamemberOffset(TCppScope_t scope, TCppIndex_t idata)
if (m->Property() & kIsStatic) {
if (strchr(cr->GetName(), '<'))
gInterpreter->ProcessLine(((std::string)cr->GetName()+"::"+m->GetName()+";").c_str());
offset = (intptr_t)m->GetOffsetCint(); // yes, CINT (GetOffset() is both wrong
offset = (intptr_t)m->GetOffsetCint(); // yes, Cling (GetOffset() is both wrong
// and caches that wrong result!
if (offset == (intptr_t)-1)
return (intptr_t)gInterpreter->ProcessLine((std::string("&")+cr->GetName()+"::"+m->GetName()+";").c_str());
} else
offset = (intptr_t)m->GetOffsetCint(); // yes, CINT, see above
offset = (intptr_t)m->GetOffsetCint(); // yes, Cling, see above
return offset;
}

Expand Down
2 changes: 1 addition & 1 deletion bindings/pyroot/cppyy/cppyy/doc/source/history.rst
Original file line number Diff line number Diff line change
Expand Up @@ -48,5 +48,5 @@ Mid 2018, version 1.0 was released.
.. _`boost.python`: https://wiki.python.org/moin/boost.python/GettingStarted
.. _`sprint at CERN`: https://morepypy.blogspot.com/2010/07/cern-sprint-report-wrapping-c-libraries.html
.. _`PyPy`: https://www.pypy.org/
.. _`Cling`: https://github.com/vgvassilev/cling
.. _`Cling`: https://github.com/root-project/cling
.. _`PyPI`: https://pypi.org/
2 changes: 1 addition & 1 deletion bindings/pyroot/cppyy/patches/using-data-members.patch
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ index ae52fbe635..d2faa2472c 100644
if (cr.GetClass()) {
- TDataMember* m = (TDataMember*)cr->GetListOfDataMembers()->At((int)idata);
+ TDataMember* m = GetDataMemberByIndex(cr, (int)idata);
// CLING WORKAROUND: the following causes templates to be instantiated first within the proper
// Cling WORKAROUND: the following causes templates to be instantiated first within the proper
// scope, making the lookup succeed and preventing spurious duplicate instantiations later. Also,
// if the variable is not yet loaded, pull it in through gInterpreter.
@@ -1944,6 +1963,10 @@ Cppyy::TCppIndex_t Cppyy::GetDatamemberIndex(TCppScope_t scope, const std::strin
Expand Down
2 changes: 1 addition & 1 deletion bindings/pyroot/pythonizations/src/TPyDispatcher.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
// ==========================
//
// The TPyDispatcher class acts as a functor that can be used for TFn's and GUIs
// to install callbacks from CINT.
// to install callbacks from Cling.

//- constructors/destructor --------------------------------------------------
TPyDispatcher::TPyDispatcher(PyObject *callable) : fCallable(0)
Expand Down
6 changes: 3 additions & 3 deletions cmake/modules/CTestCustom.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ set(CTEST_CUSTOM_WARNING_EXCEPTION ${CTEST_CUSTOM_WARNING_EXCEPTION}
"note: variable tracking size limit exceeded" # vc/tests/sse_blend.cpp
"warning is a GCC extension"
"bug in GCC 4.8.1"
"warning: please use fgets or getline instead" # deprecated use of std functions cint/ROOT
"is dangerous, better use" # deprecated use of std functions cint/ROOT
"function is dangerous and should not be used" # deprecated use of std functions cint/ROOT
"warning: please use fgets or getline instead" # deprecated use of std functions Cling/ROOT
"is dangerous, better use" # deprecated use of std functions Cling/ROOT
"function is dangerous and should not be used" # deprecated use of std functions Cling/ROOT
)
set(CTEST_CUSTOM_ERROR_EXCEPTION ${CTEST_CUSTOM_ERROR_EXCEPTION}
"fatal error: cannot open file"
Expand Down
7 changes: 0 additions & 7 deletions cmake/modules/RootConfiguration.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ foreach(v 0 OFF NO FALSE N IGNORE off no false n ignore)
set(value${v} no)
endforeach()

set(ROOT_DICTTYPE cint)
#set(ROOT_CONFIGARGS "")
set(top_srcdir ${CMAKE_SOURCE_DIR})
set(top_builddir ${CMAKE_BINARY_DIR})
Expand Down Expand Up @@ -105,11 +104,6 @@ if(IS_ABSOLUTE ${CMAKE_INSTALL_ICONDIR})
else()
set(iconpath ${prefix}/${CMAKE_INSTALL_ICONDIR})
endif()
if(IS_ABSOLUTE ${CMAKE_INSTALL_CINTINCDIR})
set(cintincdir ${CMAKE_INSTALL_CINTINCDIR})
else()
set(cintincdir ${prefix}/${CMAKE_INSTALL_CINTINCDIR})
endif()
if(IS_ABSOLUTE ${CMAKE_INSTALL_DOCDIR})
set(docdir ${CMAKE_INSTALL_DOCDIR})
else()
Expand Down Expand Up @@ -280,7 +274,6 @@ set(curseslib ${CURSES_LIBRARIES})
set(curseshdr ${CURSES_HEADER_FILE})
set(buildeditline ${value${editline}})
set(cppunit)
set(dicttype ${ROOT_DICTTYPE})


find_program(PERL_EXECUTABLE perl)
Expand Down
12 changes: 0 additions & 12 deletions cmake/modules/RootInstallDirs.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
# DATADIR - read-only architecture-independent data (DATAROOTDIR/root)
# MANDIR - man documentation (DATAROOTDIR/man)
# MACRODIR - ROOT macros (DATAROOTDIR/macros)
# CINTINCDIR - CINT include files (LIBDIR/cint)
# ICONDIR - icons (DATAROOTDIR/icons)
# SRCDIR - sources (DATAROOTDIR/src)
# FONTDIR - fonts (DATAROOTDIR/fonts)
Expand Down Expand Up @@ -93,15 +92,6 @@ endif()
# the cache and store the defaults in local variables if the cache values are
# not set explicitly. This auto-updates the defaults as DATAROOTDIR changes.

if(NOT CMAKE_INSTALL_CINTINCDIR)
if(gnuinstall)
set(CMAKE_INSTALL_CINTINCDIR "" CACHE PATH "cint includes and libraries libraries (LIBDIR/cint)")
set(CMAKE_INSTALL_CINTINCDIR "${CMAKE_INSTALL_LIBDIR}/cint")
else()
set(CMAKE_INSTALL_CINTINCDIR "cint" CACHE PATH "cint includes and libraries libraries (cint)")
endif()
endif()

if(NOT CMAKE_INSTALL_DATADIR)
set(CMAKE_INSTALL_DATADIR "" CACHE PATH "read-only architecture-independent data (DATAROOTDIR)/root")
if(gnuinstall)
Expand Down Expand Up @@ -213,7 +203,6 @@ mark_as_advanced(
CMAKE_INSTALL_DATAROOTDIR
CMAKE_INSTALL_DATADIR
CMAKE_INSTALL_MACRODIR
CMAKE_INSTALL_CINTINCDIR
CMAKE_INSTALL_ICONDIR
CMAKE_INSTALL_FONTDIR
CMAKE_INSTALL_SRCDIR
Expand All @@ -233,7 +222,6 @@ foreach(dir BINDIR
DATAROOTDIR
DATADIR
MACRODIR
CINTINCDIR
ICONDIR
FONTDIR
SRCDIR
Expand Down
8 changes: 4 additions & 4 deletions cmake/modules/RootMacros.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -627,7 +627,7 @@ function(ROOT_GENERATE_DICTIONARY dictionary)
#---what rootcling command to use--------------------------
if(ARG_STAGE1)
set(command $<TARGET_FILE:rootcling_stage1>)
set(ROOTCINTDEP rconfigure)
set(ROOTCLINGDEP rconfigure)
set(pcm_name)
else()
if(CMAKE_PROJECT_NAME STREQUAL ROOT)
Expand All @@ -636,7 +636,7 @@ function(ROOT_GENERATE_DICTIONARY dictionary)
else()
set(command ${CMAKE_COMMAND} -E env "ROOTIGNOREPREFIX=1" $<TARGET_FILE:rootcling> -rootbuild)
# Modules need RConfigure.h copied into include/.
set(ROOTCINTDEP rootcling rconfigure)
set(ROOTCLINGDEP rootcling rconfigure)
endif()
elseif(TARGET ROOT::rootcling)
set(command $<TARGET_FILE:ROOT::rootcling>)
Expand Down Expand Up @@ -694,7 +694,7 @@ function(ROOT_GENERATE_DICTIONARY dictionary)
ROOT_PCM_FILENAME "${cpp_module_file}")
endif()

#---call rootcint------------------------------------------
#---call rootcling------------------------------------------
add_custom_command(
OUTPUT ${dictionary}.cxx ${pcm_name} ${rootmap_name} ${cpp_module_file}
COMMAND ${command} -v2 -f ${dictionary}.cxx ${newargs} ${excludepathsargs} ${rootmapargs}
Expand All @@ -709,7 +709,7 @@ function(ROOT_GENERATE_DICTIONARY dictionary)
# dictionaries will be rebuilt if the C++ standard is changed in an incremental build.
-DR__DUMMY_CXX_STANDARD_${CMAKE_CXX_STANDARD}
IMPLICIT_DEPENDS ${_implicitdeps}
DEPENDS ${_list_of_header_dependencies} ${_linkdef} ${ROOTCINTDEP}
DEPENDS ${_list_of_header_dependencies} ${_linkdef} ${ROOTCLINGDEP}
${pcm_dependencies}
${MODULE_LIB_DEPENDENCY} ${ARG_EXTRA_DEPENDENCIES}
${runtime_cxxmodule_dependencies}
Expand Down
2 changes: 1 addition & 1 deletion config/rootrc.in
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ Rint.History: $(HOME)/.root_hist
# Rint.WelcomeLite: no
# When the interactive ROOT starts, it can automatically load some frequently
# used includes. However, this introduces several overheads
# - A long list of CINT and system files will be kept open during the session
# - A long list of Cling and system files will be kept open during the session
# - The initialisation takes more time (noticeable when using gdb or valgrind)
# - Memory overhead of about 5 Mbytes (1/3 of the base ROOT executable) when
# including <vector>
Expand Down
6 changes: 3 additions & 3 deletions etc/gdb-backtrace.sh
Original file line number Diff line number Diff line change
Expand Up @@ -108,11 +108,11 @@ fi
# The recommendations are based on the following assumptions:
# * More often than not, the crash is caused by user code.
# * The crash can be caused by the user's interpreted code,
# in which case sighandler() is called from CINT (G__...)
# in which case sighandler() is called from Cling (G__...)
# * The crash can be called by the user's library code,
# in which case sighandler() is called from non-CINT and
# in which case sighandler() is called from non-Cling and
# it's worth dumping the stack frames.
# * The user doesn't call CINT directly, so whenever we reach
# * The user doesn't call Cling directly, so whenever we reach
# a stack frame with "G__" we can stop.
# * The crash is caused by only one thread, the one which
# invokes sighandler()
Expand Down
3 changes: 0 additions & 3 deletions misc/win/makelib.sh
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,6 @@ if [ "$R__PLATFORM" = "win32" ]; then
cmd="$R__LD $R__SOFLAGS $R__LDFLAGS -o $dlldir/${name}.dll $R__OBJS \
$libdir/${name}.exp $R__EXTRA $syslibs"
else
if [ "$(bin/root-config --dicttype)" != "cint" ]; then
needReflex="lib/libCintex.lib lib/libReflex.lib"
fi
cmd="$R__LD $R__SOFLAGS $R__LDFLAGS -o $dlldir/${name}.dll $R__OBJS \
$libdir/${name}.exp $R__EXTRA \
$needReflex lib/libCore.lib lib/libCint.lib \
Expand Down
Loading