Merged
Conversation
ShravaniVangur
force-pushed
the
test-ci-errors
branch
from
ce57a3c to
0eb9bfa
Compare
Collaborator
|
@ShravaniVangur could try this
I noticed, restarting rook-ceph-operator pod, helped. |
Signed-off-by: subhamkrai <srai@redhat.com>
Signed-off-by: ShravaniVangur <shravanivangur@gmail.com>
ShravaniVangur
force-pushed
the
test-ci-errors
branch
from
0eb9bfa to
80e88db
Compare
subhamkrai
approved these changes
Oct 22, 2025
Collaborator
subhamkrai
left a comment
subhamkrai
left a comment
There was a problem hiding this comment.
Great to see CI working. Thanks for the PR
Madhu-1
reviewed
Oct 22, 2025
| @@ -274,11 +276,16 @@ wait_for_deployment_to_be_running() { | |||
|
|
|||
| wait_for_crd_to_be_ready() { | |||
Member
There was a problem hiding this comment.
The function name seems wrong, it should be wait for ceph_cluster_to_be_ready instead of crd_to_be_ready
Collaborator
There was a problem hiding this comment.
I'll create a separate PR to fix this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR addresses the CI test failures.
Checklist: