Impossible to use loose mode for classes

[developit]

L20 makes it impossible to use the class transformer's loose specified by presets passed to rollup-plugin-babel. This is because the class transform is manually added to the plugins list, which takes precedence over preset-provided plugins.

Is this intentional? If not, what about something like this?

const classCheck = transform( 'class Foo {}', options ).code;
if (~classCheck.indexOf('class Foo')) {
    options.plugins.push( classes );
}

[Rich-Harris]

Hmm – no, it looks like the options should get cloned rather than mutated. Most likely an oversight on my part...

[developit]

@Rich-Harris If I manually specify ['transform-es2015-classes', { loose:true }] in options.plugins, I get loose mode classes. I'm only seeing the issue when a preset specifies loose mode, such as this one.

[eventualbuddha]

This appears to no longer exhibit the same problem, so I'm closing. Please comment if I have that wrong.

[eventualbuddha]

Actually, I think it may still be a problem.

[developit]

@eventualbuddha confirmed, still an issue. Tested by removing these transforms in preact-svg, which generates strict mode class output at dist/preact-svg.js.

[Rich-Harris]

Just released 2.5.1 which no longer mutates plugins – can you verify that it behaves correctly please? thanks

[developit]

@Rich-Harris Confirmed, it's fixed! Thanks muchly.