Skip to content

feat(rolldown_plugin_transform): align with vitejs/rolldown-vite#318 #5318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2025
Merged

feat(rolldown_plugin_transform): align with vitejs/rolldown-vite#318 #5318

merged 1 commit into from
Jul 17, 2025

Conversation

@shulaoda
Copy link
Member

@shulaoda shulaoda commented Jul 17, 2025 •
edited
Loading

closes #5313

@shulaoda Graphite App
Copy link
Member Author

shulaoda commented Jul 17, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Jul 17, 2025

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 11edea7
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/687879fd561b7d00085f5a1d

@shulaoda shulaoda changed the title feat(rolldown_plugin_transform): align with vitejs/rolldown-vite#318 feat(rolldown_plugin_transform): align with vitejs/rolldown-vite#318 Jul 17, 2025
@shulaoda shulaoda marked this pull request as ready for review July 17, 2025 04:21
@github-actions
Copy link
Contributor

github-actions bot commented Jul 17, 2025

Benchmarks Rust

  • target: main(f367075)
  • pr: 07-17-feat_rolldown_plugin_transform_align_with_vitejs_rolldown-vite_318(11edea7)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     82.9±2.88ms        ? ?/sec    1.02     84.7±2.65ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.03     97.0±2.20ms        ? ?/sec    1.00     94.2±2.13ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    119.6±4.44ms        ? ?/sec    1.01    121.0±2.06ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    143.1±2.78ms        ? ?/sec    1.00    143.7±3.10ms        ? ?/sec
bundle/bundle@threejs                                        1.00     43.7±0.99ms        ? ?/sec    1.02     44.7±0.93ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     53.9±0.83ms        ? ?/sec    1.01     54.3±0.75ms        ? ?/sec
bundle/bundle@threejs10x                                     1.03    466.6±7.99ms        ? ?/sec    1.00    452.7±4.51ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.02    550.9±6.20ms        ? ?/sec    1.00    540.0±3.96ms        ? ?/sec
scan/scan@rome_ts                                            1.03     97.8±2.06ms        ? ?/sec    1.00     95.3±2.07ms        ? ?/sec
scan/scan@threejs                                            1.04     33.8±2.04ms        ? ?/sec    1.00     32.5±0.53ms        ? ?/sec
scan/scan@threejs10x                                         1.01    343.7±4.20ms        ? ?/sec    1.00    339.0±4.52ms        ? ?/sec

@shulaoda shulaoda added this pull request to the merge queue Jul 17, 2025
Merged via the queue into main with commit 23242a0 Jul 17, 2025
27 checks passed
@shulaoda shulaoda deleted the 07-17-feat_rolldown_plugin_transform_align_with_vitejs_rolldown-vite_318 branch July 17, 2025 04:46
This was referenced Jul 17, 2025
Closed
Merged
shulaoda pushed a commit that referenced this pull request Jul 17, 2025
@github-actions @IWANABETHATGUY
release: v1.0.0-beta.28 (#5329)
4afe097 
## [1.0.0-beta.28] - 2025-07-17

### 🚀 Features

- rolldown: oxc v0.77.2 (#5328) by @Boshen
- hmr: add `module` and `exports` parameters to CJS initializer
functions (#5322) by @hyf0
- rolldown_plugin_transform: align with `vitejs/rolldown-vite#318`
(#5318) by @shulaoda
- rolldown_plugin_transform: align with `vitejs/rolldown-vite#315`
(#5315) by @shulaoda
- hmr: automatically disable treeshaking in hmr (#5311) by @hyf0
- hmr: use `trait HmrAstBuilder` to unify ast construction (#5310) by
@hyf0
- rolldown_plugin_chunk_import_map: basic implementation (#5307) by
@shulaoda
- add `watch.onInvalidate` (#5239) by @situ2001
- rolldown_plugin_chunk_import_map: implement initial `render_chunk`
logic (#5306) by @shulaoda
- rolldown: oxc v0.77.1 (#5304) by @Boshen
- js: expose `experimental.incrementalBuild` option (#5300) by
@IWANABETHATGUY
- js: support `experimental.onDemandWrapping` option (#5299) by
@IWANABETHATGUY
- support on demand wrapping for entry chunk (#5291) by @IWANABETHATGUY
- rolldown_plugin_chunk_import_map: initialize (#5289) by @shulaoda
- show owner module id for "canonical name not found for" errors (#5288)
by @sapphi-red

### 🐛 Bug Fixes

- only transform VarDeclaration when enable `keepNames` (#5323) by
@IWANABETHATGUY
- keepNames with special Ifstmt (#5320) by @IWANABETHATGUY
- incremental watch panic when adding dynamic import (#5309) by
@IWANABETHATGUY
- make leaf module wrapping optimization opt-in (#5305) by
@IWANABETHATGUY
- `keepNames` should consider exportNamed function declaration (#5298)
by @IWANABETHATGUY
- undefined `process.versions` for browser build (#5295) by @sxzz
- sanitizeFileName: entry name should be sanitized (#5283) by @shulaoda
- minify-internal-exports: ensure minifying internal exports stably
(#5281) by @hyf0
- keep legal and annotation comments for `minify: 'dce-only'` (#5280) by
@sapphi-red
- unstable chunk generation when `preserveEntrySignatures: false` is
used (#5274) by @IWANABETHATGUY

### 🚜 Refactor

- pass the while CodegenOptions to `EcmaCompiler::minify` (#5279) by
@sapphi-red
- avoid iterate `canonical_exports` twice (#5276) by @IWANABETHATGUY

### 📚 Documentation

- pluginutils: add README file (#5262) by @TheAlexLichter

### ⚡ Performance

- inline function expression when rewriting `name` property with
`keepNames` enabled (#5321) by @IWANABETHATGUY
- rolldown_sourcemap: cache source id -> source text mapping (#5285) by
@Boshen
- rolldown_sourcemap: disable rayon (#5284) by @Boshen

### 🧪 Testing

- rust: prevent meaningless snapshot change from bumping oxc runtime
versions (#5312) by @hyf0

### ⚙️ Miscellaneous Tasks

- upgrade to NAPI-RS 3.0 stable (#5324) by @Brooooooklyn
- infra: add onlyBuiltDependencies (#5287) by @situ2001
- improve the order of import keys in the exports field (#5314) by @btea
- deps: update dependency rolldown-plugin-dts to v0.13.14 (#5293) by
@renovate[bot]
- deps: lock file maintenance rust crates (#5267) by @renovate[bot]
- deps: lock file maintenance npm packages (#5266) by @renovate[bot]
- deps: update github-actions (#5265) by @renovate[bot]

### ❤️ New Contributors

* @situ2001 made their first contribution in
[#5287](#5287)

Co-authored-by: IWANABETHATGUY <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Align the new behaviors of plugins with rolldown-vite

3 participants

@shulaoda @IWANABETHATGUY