Skip to content

Fixed #657 Param $len should not be implicitly nullable.#658

Merged
danielmorell merged 1 commit intomasterfrom
fixed/issue-657-implicitly-null-len-parameter
May 2, 2025
Merged

Fixed #657 Param $len should not be implicitly nullable.#658
danielmorell merged 1 commit intomasterfrom
fixed/issue-657-implicitly-null-len-parameter

Conversation

@danielmorell
Copy link
Collaborator

Description of the change

This PR resolves a deprecation in PHP 8.4 that requires paramaters to be explicitly nullable.

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Related issues

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@danielmorell danielmorell requested a review from brianr May 2, 2025 19:53
@danielmorell danielmorell merged commit 9c28cd7 into master May 2, 2025
18 checks passed
@danielmorell danielmorell deleted the fixed/issue-657-implicitly-null-len-parameter branch May 2, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implicitly marking parameter $len as nullable is deprecated

2 participants