Skip to content

chore: add ci tests for --prefer-lowest #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielmorell merged 5 commits into from
Apr 29, 2023
Merged

chore: add ci tests for --prefer-lowest #624

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c1ce2d5
chore: add ci tests for --prefer-lowest
Chris8934 Apr 21, 2023
025fb60
Merge branch 'master' into chore/add-test-prefer-lowest
danielmorell Apr 21, 2023
dbe4d44
Merge branch 'master' into chore/add-test-prefer-lowest
danielmorell Apr 28, 2023
26358e6
Merge branch 'master' into chore/add-test-prefer-lowest
danielmorell Apr 28, 2023
2559c28
Merge branch 'master' into chore/add-test-prefer-lowest
waltjones Apr 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions .github/workflows/ci-3.x.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ on:
branches:
- next/3.x/**
schedule:
# Every day at 02:42
# Every day at 02:42
- cron: '42 2 * * *'

jobs:
Expand All @@ -35,17 +35,23 @@ jobs:
# @see https://www.dereuromark.de/2019/01/04/test-composer-dependencies-with-prefer-lowest/
php-tests:
strategy:
fail-fast: false
matrix:
# All the versions, OS, and dependency levels we want to support
php: [8.0, 8.1, 8.2]
dependency: [stable] # TODO: lowest
os: [ubuntu] # TODO: windows, macos
os: [ ubuntu ] # TODO: windows, macos
php: [ '8.0', '8.1', '8.2' ]
dependency: [ stable ]
# Our code has paths for with- and without- XDebug, and we want to test
# both of them.
# @see https://xdebug.org/docs/all_settings#mode
xdebug3-mode: ["xdebug.mode=develop,coverage", "xdebug.mode=coverage"]
xdebug3-mode: ['develop,coverage', 'coverage']
include:
- php: '8.0'
os: 'ubuntu'
dependency: 'lowest'
xdebug3-mode: 'develop,coverage'

name: PHP ${{ matrix.php }} on ${{ matrix.os }}, ${{ matrix.dependency }} dependencies preferred
name: PHP ${{ matrix.php }} on ${{ matrix.os }}, ${{ matrix.dependency }} dependencies preferred, ${{ matrix.xdebug3-mode }}
runs-on: ${{ matrix.os }}-latest
steps:
- name: Checkout the next/3.x/main branch during scheduled builds
Expand All @@ -63,7 +69,7 @@ jobs:
with:
php-version: ${{ matrix.php }}
extensions: curl
ini-values: zend.exception_ignore_args=Off, ${{ matrix.xdebug3-mode }}
ini-values: zend.exception_ignore_args=Off, xdebug3-mode="${{ matrix.xdebug3-mode }}"
coverage: xdebug

- name: Get composer cache directory
Expand Down
16 changes: 11 additions & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,17 +32,23 @@ jobs:
# @see https://www.dereuromark.de/2019/01/04/test-composer-dependencies-with-prefer-lowest/
php-tests:
strategy:
fail-fast: false
matrix:
# All the versions, OS, and dependency levels we want to support
php: [8.0, 8.1, 8.2]
dependency: [stable] # TODO: lowest
os: [ubuntu] # TODO: windows, macos
php: [ '8.0', '8.1', '8.2' ]
dependency: [ stable ]
# Our code has paths for with- and without- XDebug, and we want to test
# both of them.
# @see https://xdebug.org/docs/all_settings#mode
xdebug3-mode: ["xdebug.mode=develop,coverage", "xdebug.mode=coverage"]
xdebug3-mode: ['develop,coverage', 'coverage']
include:
- php: '8.0'
os: 'ubuntu'
dependency: 'lowest'
xdebug3-mode: 'develop,coverage'

name: PHP ${{ matrix.php }} on ${{ matrix.os }}, ${{ matrix.dependency }} dependencies preferred
name: PHP ${{ matrix.php }} on ${{ matrix.os }}, ${{ matrix.dependency }} dependencies preferred, ${{ matrix.xdebug3-mode }}
runs-on: ${{ matrix.os }}-latest
steps:
- name: Checkout the code
Expand All @@ -53,7 +59,7 @@ jobs:
with:
php-version: ${{ matrix.php }}
extensions: curl
ini-values: zend.exception_ignore_args=Off, ${{ matrix.xdebug3-mode }}
ini-values: zend.exception_ignore_args=Off, xdebug3-mode="${{ matrix.xdebug3-mode }}"
coverage: xdebug

- name: Get composer cache directory
Expand Down