Skip to content

Fixed #613 Added response status code to verbose log message. #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielmorell merged 3 commits into from
Apr 18, 2023
Merged

Fixed #613 Added response status code to verbose log message. #614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
820198c
Fixed #613 Added response status code to verbose log message.
danielmorell Apr 12, 2023
8478f30
Added colon to verbose log between status and message.
danielmorell Apr 12, 2023
6682cdb
Merge branch 'master' into fixed/613-verbose-log-fail-status
danielmorell Apr 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/RollbarLogger.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,8 @@ public function report(
} elseif ($response->getStatus() >= 400) {
$info = $response->getInfo();
$this->verboseLogger()->error(
'Occurrence rejected by the API: ' . ($info['message'] ?? 'message not set')
'Occurrence rejected by the API: with status ' . $response->getStatus() . ': '
. ($info['message'] ?? 'message not set')
);
} else {
$this->verboseLogger()->info('Occurrence successfully logged');
Expand Down
6 changes: 3 additions & 3 deletions tests/VerbosityTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,13 +227,13 @@ public function testRollbarLoggerResponseStatusZero(): void
public function testRollbarLoggerResponseStatusError(): void
{
Rollbar::init([
'access_token' => $this->getTestAccessToken(),
// Invalid access token should cause a 403 response.
'access_token' => '00000000000000000000000000000000',
'environment' => 'testing-php',
'verbose_logger' => $this->verboseLogger,
'endpoint' => 'https://api.rollbar.com/api/foo/',
]);
Rollbar::log(LogLevel::INFO, "Testing PHP Notifier");
$this->assertVerboseLogContains('Occurrence rejected by the API:', LogLevel::ERROR);
$this->assertVerboseLogContains('Occurrence rejected by the API: with status 403: ', LogLevel::ERROR);
}

/**
Expand Down