Check if constant exists before defining#32
Merged
Conversation
This fixes problems when running tests with PHPUnit.
Member
|
Thanks! We'll review and get this merged, most likely today. |
Contributor
|
Thanks @kidk! Merged and released as version 0.9.5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are getting a lot of errors after upgrading to the latest version. The problem is that PHP cannot redefine a constant, so I added a check to see if it already exists before defining again.
Example error:
[exec] 5) ApiControllerTest::testFeedbackSpecialChars
[exec] PHPUnit_Framework_Exception: PHP Notice: Constant ROLLBAR_INCLUDED_ERRNO_BITMASK already defined in /var/lib/jenkins/jobs/ci_development/workspace/protected/vendors/rollbar/rollbar.php on line 81
[exec] PHP Stack trace: