Skip to content

Conversation

@danielmorell
Copy link
Collaborator

Description of the change

This PR solves an issue where some settings could not be saved becaues they matched the default value. This was intentional for some settings that have never had the values changed from the default. However, for more critical settings, especially those that are populated into the settings array via dedicated methods this caused issues.

This resolves issue #137 as well as ensures it is fixed for the other "critical" settings values.

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Related issues

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@danielmorell danielmorell added this to the 3.1.0 milestone Nov 7, 2025
@danielmorell danielmorell requested a review from brianr November 7, 2025 14:09
@danielmorell danielmorell merged commit c5b8be5 into master Nov 7, 2025
24 checks passed
@danielmorell danielmorell deleted the fixed/issue-137-cannot-save-production-environment branch November 7, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3.0.0 - Cannot set "production" as environment name

3 participants