Skip to content

bugfix enum field inline comment syntax highlighting #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 28, 2025
Merged

bugfix enum field inline comment syntax highlighting #635

merged 4 commits into from
Mar 28, 2025

Conversation

@sethmaclean
Copy link
Collaborator

@sethmaclean sethmaclean commented Mar 26, 2025 •
edited
Loading

This PR adds syntax highlighting to inline comments made on enum fields, see bug for more details --> #362

image

@sethmaclean sethmaclean self-assigned this Mar 26, 2025
@sethmaclean
Copy link
Collaborator Author

sethmaclean commented Mar 26, 2025 •
edited
Loading

@TwitchBronBron
In fixing this test, I broke the embedded logic in enum_declaration for the body out to a separate object labelled "enum_field" & included it in enum_dec. LMK if you want that reverted or named to something more appropriate

TwitchBronBron
TwitchBronBron reviewed Mar 27, 2025
View reviewed changes
@TwitchBronBron TwitchBronBron merged commit a0ebe2f into master Mar 28, 2025
5 checks passed
@TwitchBronBron TwitchBronBron deleted the bugfix-enum-field-inline-comment-syntax-highlighting branch March 28, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TwitchBronBron TwitchBronBron TwitchBronBron approved these changes

@chrisdp chrisdp Awaiting requested review from chrisdp

Assignees

@sethmaclean sethmaclean

Labels

SyntaxHighlighting

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sethmaclean @TwitchBronBron