syntax highlighting keyword modifier class #629
+871
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… interface declaration
sethmaclean
changed the base branch from
master
to
bug-fix-syntax-highlighting-return-statements
TwitchBronBron
requested changes
Mar 21, 2025
Member
TwitchBronBron
left a comment
TwitchBronBron
left a comment
There was a problem hiding this comment.
I have a few suggestions. Also, can you add some unit tests to verify the colorization works in interface declarations, and also that we are not capturing optional as blue in other situations (like function names, parameters, and variables).
| }, | ||
| "interface_field": { | ||
| "begin": "(?i)\\s*\\b([a-z0-9_]+)(?:[\\s\\t]*(as))?", | ||
| "begin": "(?i)\\s*\\b([a-z0-9_]+)(?:[\\s\\t]*(as))", |
Member
There was a problem hiding this comment.
I think we might want to add optional in this regex as an additional optional capture group rather than capturing it as its unique named item.
…tax-highlighting-keyword-modifier-class
Collaborator
Author
|
still not working quite right, the following fields are not styling properly due to overlapping issues with the function logic in entire_language |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the keyword modifier class for syntax highlighting when the "optional" keyword is used in interface declarations.
Note: There may very well be a separate class that we would like to store this value in instead. if so please LMK and I will make the necessary adjustments.
Before:
After:
