bugFix/syntax highlighting on AA function names #627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TwitchBronBron
requested changes
Mar 21, 2025
Member
TwitchBronBron
left a comment
TwitchBronBron
left a comment
There was a problem hiding this comment.
Thanks for this. Can you add some unit tests to verify this is working correctly (and ensure we don't break it again in the future)?
…g reserved function names
TwitchBronBron
approved these changes
Mar 24, 2025
Member
TwitchBronBron
left a comment
TwitchBronBron
left a comment
There was a problem hiding this comment.
Looks great! thanks for this.
TwitchBronBron
deleted the
bug-fix-syntax-highlighting-variables-and-params
branch
This was referenced Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is linked to issue #397
It was discovered that the
support-component-functionclasses were applying text-mate styles to functions that should not be receiving them. reserved function names already receive syntax highlighting following the regex colourization, by the semantic styling in bright-script. as a result, all references to the support component class objects have been removed from the tmLanguage.bs file.Unit tests have been added to validate the highlighting of functions and variables named that match reserved function names in Roku.