Merged
Conversation
01b9379 to
94f0ca1
Compare
94f0ca1 to
3024166
Compare
hit 100% coverage.
chrisdp
approved these changes
Mar 16, 2022
NathanGillis
approved these changes
Mar 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes several performance issues related to globbing for files.
fast-glob. (EDIT: fdir has a few other design differences that prevent us from switching. fast-glob is plenty fast).To benchmark this, I ran the following roku-deploy command against a folder with >64,000 files:
Results:
baseline (before rewrite):
24.409 ops/sec, duration: 47s318ms
after rewrite (using node-glob):
916.974 ops/sec, duration: 1s626ms
after rewrite (using fast-glob):
3,147.138 ops/sec, duration: 0s367ms