-
Notifications
You must be signed in to change notification settings - Fork 22
Add support for detecting ecpNetworkAccessMode #223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
87b392e
Add a new helper function to get the ecpSettingMode from the device. …
Christian-Holbrook 530f651
Address PR comments. Update ECPSettingMode to EcpNetworkAccessMode
Christian-Holbrook f0bab23
Address PR comments. Update ECPSettingMode to EcpNetworkAccessMode
Christian-Holbrook 22d6a1c
Add unit tests to get 100% coverage
Christian-Holbrook 410a8f5
Remove null tests
Christian-Holbrook f64696b
Add a unit test to test every branch in the optional chaining
Christian-Holbrook 483568c
Rename error, tweak error message
TwitchBronBron d591672
Consolidate a few tests
TwitchBronBron 3a8d276
browserlist updates
TwitchBronBron File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be
EcpNetworkAccessModeDisabledError? becauseECP network access modeis currently set to disabled?