Merged
Conversation
src/cli.ts
Outdated
| return new SendTextCommand().run(args); | ||
| }) | ||
|
|
||
| .command('interactive', 'Provides a way to send a series of ECP key events similar to how Roku Remote Tool works but from the command line', (builder) => { |
Member
There was a problem hiding this comment.
Chris and I played around with some alternative names. How about:
remote-control
So usage would be:
npx roku-deploy remote-control
We could add an alias like RC or R or something if that feels verbose?
Collaborator
Author
There was a problem hiding this comment.
updated. Added rc shorter version as well
src/commands/RemoteControl.ts
Outdated
| import type { RokuKey } from '../index'; | ||
| import { rokuDeploy, util } from '../index'; | ||
|
|
||
| export class RemoteControl { |
Member
There was a problem hiding this comment.
Let's call this class RemoteControlCommand and the file RemoteControlCommand.ts to align with the other files in this folder.
TwitchBronBron
approved these changes
Jun 10, 2024
Member
TwitchBronBron
left a comment
TwitchBronBron
left a comment
There was a problem hiding this comment.
Once you rename the class, then this can be merged. Nice work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.