Upgrade typescript & other packages#157
Merged
TwitchBronBron merged 101 commits intov4from Apr 1, 2024
Merged
Conversation
… old behavior, add 2 more tests that look for new behavior
Co-authored-by: Bronley Plumb <[email protected]>
# Conflicts: # src/RokuDeploy.ts
# Conflicts: # src/util.ts
# Conflicts: # src/RokuDeploy.ts # src/cli.ts # src/commands/DeleteInstalledChannelCommand.ts # src/commands/GetDeviceInfoCommand.ts # src/commands/PrepublishCommand.ts # src/commands/PublishCommand.ts # src/commands/SignExistingPackageCommand.ts # src/commands/TakeScreenshotCommand.ts # src/commands/ZipPackageCommand.ts # src/index.ts # src/util.spec.ts # src/util.ts
# Conflicts: # src/index.ts
…comments, delete unnecessary command/tests/options, partially fix exec command
…ms' into upgrade-typescript
…oalescing set to false, propert results should be set as a class property, optional chaining, and no redundant types
# Conflicts: # src/RokuDeploy.spec.ts
src/RokuDeploy.spec.ts
Outdated
| import * as r from 'postman-request'; | ||
| import type * as requestType from 'request'; | ||
| import type { CaptureScreenshotOptions, ConvertToSquashfsOptions, CreateSignedPackageOptions, DeleteDevChannelOptions, GetDevIdOptions, GetDeviceInfoOptions, RekeyDeviceOptions, SendKeyEventOptions, SideloadOptions } from './RokuDeploy'; | ||
| import { RokuDeploy, type CaptureScreenshotOptions, type ConvertToSquashfsOptions, type CreateSignedPackageOptions, type DeleteDevChannelOptions, type GetDevIdOptions, type GetDeviceInfoOptions, type RekeyDeviceOptions, type SendKeyEventOptions, type SideloadOptions } from './RokuDeploy'; |
Member
There was a problem hiding this comment.
Let's revert this one. I prefer having 1 "import {notTypeStuff}" and then another line for "import type {typeStuff}". Freel free to tweak any eslint rules that complain about that.
Collaborator
Author
There was a problem hiding this comment.
The only thing is this no duplicate import rule doesn't have an option to exclude this scenario and to disable it means it won't create an error if we import from the same file multiple times, which I think that is a good error to have right?
Collaborator
Author
There was a problem hiding this comment.
I just disabled it for the one line
TwitchBronBron
requested changes
Apr 1, 2024
Member
TwitchBronBron
left a comment
TwitchBronBron
left a comment
There was a problem hiding this comment.
This looks great. Just one issue with the eslint-disable comment, then this is good to go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #147