TBD-67: roku-deploy: fix nodejs 19 bug#115
Merged
TwitchBronBron merged 1 commit intomasterfrom May 10, 2023
Merged
Conversation
'Request' module post requests fail with Nodejs v19 and up. To make it compatible with newer versions of node simply pass the following config values to the request apis to overcome socket error:
agentOptions: { 'keepAlive': false }
Member
|
Looks like it works for me on node 16 and node 19. |
TwitchBronBron
approved these changes
May 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
'Request' module post requests fail with Nodejs v19 and up. To make it compatible with newer versions of node simply pass the following config values to the request apis to overcome socket error: agentOptions: { 'keepAlive': false }