Use micromatch instead of picomatch#109
Merged
TwitchBronBron merged 3 commits intomasterfrom Mar 14, 2023
Merged
Conversation
|
But is that the same version as |
Align micromatch version with one from fast-glob
Member
Author
Good call! There was a patch release of fast-glob ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use
fast-globfor file discovery (which usesmicromatchfor glob logic), but for some reason were usingpicomatchfor our path filtering logic.This PR aligns on
micromatchfor path filtering logic, meaning that now all glob logic within roku-deploy is handled using the same library.