Fix bug with stagingDir fallback not working#1606
Merged
TwitchBronBron merged 2 commits intov1from Jan 13, 2026
Merged
Conversation
TwitchBronBron
commented
Jan 13, 2026
| public normalizeAndResolveConfig(config: BsConfig | undefined): FinalizedBsConfig { | ||
| let result = this.normalizeConfig({}); | ||
| let result = this.normalizeConfig({ | ||
| ...config |
Member
Author
There was a problem hiding this comment.
This was the fix. We need to pass along a copy of the incoming config so we have access to deprecated props when loading defaults
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we deprecated
stagingDir, the backwards-compatibility logic was broken that was supposed to usestagingDirorstagingFolderPathasoutDirwhenoutDirwas not specified.This fixes that.