Merged
Conversation
Collaborator
Author
|
addresses #1496 |
Collaborator
Author
|
Huge improvement! Reduces re-validation by a factor of 10, when there's no potential changes to external files. |
Collaborator
Author
|
I think I can make this a little bit better. |
Collaborator
Author
|
Ready for review, @TwitchBronBron |
TwitchBronBron
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At some point, the code was changed to run
Scope.validate()on all scopes for every validation cycle, however, the step before that in the validation cycle, we find the list of scopes we actually need to re-validate.This PR makes it so only the scopes that need it get revalidated.
Metrics (change of content of a string, so should not force any revalidation):
Before:
After:
And this is for when there is a symbol change (in a file used in every scope):
Before:
After: