Merged
Conversation
TwitchBronBron
requested changes
Aug 29, 2025
Member
TwitchBronBron
left a comment
There was a problem hiding this comment.
Nice first pass. Just a few suggestions here. I'd also say that anytime we could convert one of the deleted props to a new prop, let's do that. (I think I addressed all of them already though).
Would be nice to include "we deleted xyz in v1" in some "upgrading from v0 to v1" docs section. Is there something like that in here yet? If not, maybe add a new section somewhere with just this change, we can expand upon it later.
TwitchBronBron
requested changes
Sep 4, 2025
Co-authored-by: Bronley Plumb <[email protected]>
Co-authored-by: Bronley Plumb <[email protected]>
…d values they are replacing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are removing the
zipandsideloadfunctionality frombrighterscript.roku-deployshould be used instead.With this removal, the following parameters are being removed from bsconfig and cli: