Skip to content

#1555 Remove zip and sideload#1562

Merged
TwitchBronBron merged 15 commits intov1from
issue-1555-remove-zip-and-sideload
Sep 4, 2025
Merged

#1555 Remove zip and sideload#1562
TwitchBronBron merged 15 commits intov1from
issue-1555-remove-zip-and-sideload

Conversation

@Christian-Holbrook
Copy link
Contributor

We are removing the zip and sideload functionality from brighterscript. roku-deploy should be used instead.

With this removal, the following parameters are being removed from bsconfig and cli:

  1. create-package
  2. copy-to-staging -> renamed to no-emit
  3. deploy
  4. host
  5. password
  6. retain-staging-folder
  7. staging-folder-path -> renamed to out-dir
  8. username

Copy link
Member

@TwitchBronBron TwitchBronBron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice first pass. Just a few suggestions here. I'd also say that anytime we could convert one of the deleted props to a new prop, let's do that. (I think I addressed all of them already though).

Would be nice to include "we deleted xyz in v1" in some "upgrading from v0 to v1" docs section. Is there something like that in here yet? If not, maybe add a new section somewhere with just this change, we can expand upon it later.

Copy link
Member

@TwitchBronBron TwitchBronBron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@TwitchBronBron TwitchBronBron marked this pull request as ready for review September 4, 2025 18:58
@TwitchBronBron TwitchBronBron enabled auto-merge (squash) September 4, 2025 18:58
@TwitchBronBron TwitchBronBron merged commit 9b06be1 into v1 Sep 4, 2025
8 checks passed
@TwitchBronBron TwitchBronBron deleted the issue-1555-remove-zip-and-sideload branch September 4, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants