Add max depth configuration for Roku project discovery#1533
Merged
TwitchBronBron merged 4 commits intomasterfrom Jul 17, 2025
Merged
Add max depth configuration for Roku project discovery#1533TwitchBronBron merged 4 commits intomasterfrom
TwitchBronBron merged 4 commits intomasterfrom
Conversation
Co-authored-by: TwitchBronBron <[email protected]>
Copilot
AI
changed the title
[WIP] Add max depth for searching for roku projects
Add max depth configuration for Roku project discovery
Jul 17, 2025
TwitchBronBron
requested changes
Jul 17, 2025
…unction, fix depth tests Co-authored-by: TwitchBronBron <[email protected]>
TwitchBronBron
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a configurable maximum depth limit when searching for Roku projects to prevent infinite loops and improve performance in deeply nested directory structures.
Changes Made
maxDepthconfiguration: New optional setting inbrightscript.languageServer.maxDepthwith a default value of 15discoverProjectsForWorkspacemethod to respect the depth limit when searching for:bsconfig.jsonfilesmanifestfiles (for Roku projects)BrightScriptClientConfigurationandWorkspaceConfiginterfaces to include the newmaxDepthpropertyTesting
Added comprehensive unit tests covering:
Usage
The maxDepth can be configured in VSCode settings:
{ "brightscript.languageServer.maxDepth": 10 }If not specified, the default value of 15 will be used, which should handle most reasonable project structures while preventing performance issues with excessively deep directory trees.
Fixes #1528.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.