Add enableDiscovery language server option#1520
Merged
TwitchBronBron merged 4 commits intomasterfrom Jun 25, 2025
Merged
Conversation
elsassph
force-pushed
the
feature/optional-discovery
branch
2 times, most recently
from
9eb12da to
2116fc7
Compare
elsassph
force-pushed
the
feature/optional-discovery
branch
from
2116fc7 to
a8e3e33
Compare
TwitchBronBron
requested changes
Jun 24, 2025
Member
TwitchBronBron
left a comment
TwitchBronBron
left a comment
There was a problem hiding this comment.
PR looks great....except it doesn't look like the enableDiscovery option is actually used anywhere?
Contributor
Author
|
oh dear, now with code using the |
TwitchBronBron
approved these changes
Jun 24, 2025
TwitchBronBron
approved these changes
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem with automatic discovery
The language server aggressively tries to discover Roku projects by default.
This is fine for Roku-only developers, and developers working in small to medium repositories.
This is causing issues for developers working on large codebases, like monorepos, and developers working on a lot of non-Roku projects, where the extension goes in the way. For instance in our monorepo, the language server goes out of memory while validating the projects, repeatedly as VS attempts to restart the server.
Adding a setting allowing to disable automatic discovery
This PR adds an
enableDiscoverylsp option, which defaults totruebut can be disabled.Uncovered issues
While adding the option, it turned out some refactoring had been done incorrectly; for instance
enableThreadingwas never enabled due to incorrect workspace config preparation using unsafe casting.Fixing the workspace config caused some unit tests to fail (some rather mysteriously).
While fixing the unit tests, I found that we have some questionable logic: why not ensure a
nametoken is available inBrsValidator?