Skip to content

Improve manifests discovery #1518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TwitchBronBron merged 1 commit into from
Jun 24, 2025
Merged

Improve manifests discovery #1518

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions src/lsp/ProjectManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -667,13 +667,14 @@ export class ProjectManager {
//look for roku project folders
let rokuLikeDirs = (await Promise.all(
//find all folders containing a `manifest` file
(await rokuDeploy.getFilePaths([
'**/manifest',
...excludePatterns

//is there at least one .bs|.brs file under the `/source` folder?
], workspaceConfig.workspaceFolder)).map(async manifestEntry => {
const manifestDir = path.dirname(manifestEntry.src);
(await fastGlob(['**/manifest', ...excludePatterns], {
cwd: workspaceConfig.workspaceFolder,
followSymbolicLinks: false,
absolute: true,
onlyFiles: true
})).map(async manifestEntry => {
const manifestDir = path.dirname(manifestEntry);
//TODO validate that manifest is a Roku manifest
const files = await rokuDeploy.getFilePaths([
'source/**/*.{brs,bs}',
...excludePatterns
Expand Down