Skip to content

Improve bsconfig.json auto-discovery#1512

Merged
TwitchBronBron merged 3 commits intomasterfrom
fix/bsconfig-discovery
Jun 13, 2025
Merged

Improve bsconfig.json auto-discovery#1512
TwitchBronBron merged 3 commits intomasterfrom
fix/bsconfig-discovery

Conversation

@elsassph
Copy link
Contributor

@elsassph elsassph commented Jun 13, 2025

Problems

There are issues with bsconfig.json auto-discovery:

  • Language server may crash with large monorepos making use of symlinks; implementation uses rokuDeploy.getFilePaths which is quite inefficient for our need,
  • bsconfig.json are looked into Search-excluded locations.

Changes

  • replaces rokuDeploy.getFilePaths with a direct fastGlob call with followSymbolicLinks disabled,
  • add Search exclude to the filters

Behaviour change

Some users may rely on symlinks or search-hidden locations; this can be worked around by adding manually folders in the Workspace.

@elsassph elsassph force-pushed the fix/bsconfig-discovery branch from eadb543 to 14e17d2 Compare June 13, 2025 09:56
Copy link
Member

@TwitchBronBron TwitchBronBron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TwitchBronBron TwitchBronBron enabled auto-merge June 13, 2025 15:22
@TwitchBronBron TwitchBronBron disabled auto-merge June 13, 2025 15:23
@TwitchBronBron TwitchBronBron merged commit 41eb8fd into master Jun 13, 2025
7 checks passed
@TwitchBronBron TwitchBronBron deleted the fix/bsconfig-discovery branch June 13, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants