Skip to content

Fix ForEach variable typing issues#1498

Merged
TwitchBronBron merged 5 commits intov1from
fix/foreach_variable_issue
Jun 3, 2025
Merged

Fix ForEach variable typing issues#1498
TwitchBronBron merged 5 commits intov1from
fix/foreach_variable_issue

Conversation

@markwpearce
Copy link
Collaborator

@markwpearce markwpearce commented May 22, 2025

Fixes the issue where the loop variable in a for each statement might be randomly untyped.
Remove caching for array default types
Fixes not added unresolved array default types to the list of unresolved symbols for re-validation

Eg:

  • in FileA, we do for loop with collection of interface.
  • in FileB, we change the type of the thing in that interface
  • must edit FileA to see the diagnostics show up (or get fixed)

Fixes: #1466

@markwpearce markwpearce added this to the v1.0.0 milestone May 22, 2025
@markwpearce markwpearce changed the title Remove caching for array default types Fix ForEach variable typing issues May 23, 2025
@TwitchBronBron TwitchBronBron enabled auto-merge June 3, 2025 19:47
@TwitchBronBron TwitchBronBron merged commit 98cb32a into v1 Jun 3, 2025
8 checks passed
@TwitchBronBron TwitchBronBron deleted the fix/foreach_variable_issue branch June 3, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants