Emit the afterProgramValidate event even when validation is cancelled#1381
Merged
TwitchBronBron merged 5 commits intolsp-refactorfrom Dec 23, 2024
Merged
Emit the afterProgramValidate event even when validation is cancelled#1381TwitchBronBron merged 5 commits intolsp-refactorfrom
afterProgramValidate event even when validation is cancelled#1381TwitchBronBron merged 5 commits intolsp-refactorfrom
Conversation
…terscript into better-validate-cancel-recovery
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we cancel validations, we need to ensure that we still emit the
afterProgramValidateevent to allow plugins to clean up after that flow. We include awasCancelledboolean as an event argument, this way plugins can make different decisions based on if it was cancelled or not.This solves the vanishing diagnostic bug where typing in quick succession that triggered a cancel would cause certain scope diagnostics to vanish.