Spurious error BS1001?

[ZeeD]

example snippet:

sub foo(flag as boolean)
    ' both cases set ret
    if flag
        ret = "foo"
    else
        ret = "bar"
    end if

    print ret
end sub

I have updated brighterscript from 0.57.2 to 0.58.0 and then now bsc triggers the error error BS1001: Cannot find name 'ret'. My understanding is that ret is actually been set, so bsc shouldn't trigger this error

(moreover I found this error in some libraries I use, like https://github.com/rokucommunity/roku-requests/blob/master/src/source/Requests.brs#L177 trigger the same BS1001 error, so it's a bit complex to fix myself)

[TwitchBronBron]

I started #698 to fix this exact issue the other day, but my implementation has a bug. I'm hoping to get it fixed in the next few days.

For now, you can mitigate the issue in your own code by lifting the ret value above the if statement.

sub foo(flag as boolean)
    ret = invalid
    ' both cases set ret
    if flag
        ret = "foo"
    else
        ret = "bar"
    end if

    print ret
end sub

[ZeeD]

I don't know if this is related or not, but I found another different behavior with this new release:

namespace ns
    sub foo()
        bar()
    end sub

    sub bar()
        ' ...
    end sub
end namespace

this snippet now triggers error BSLINT1001: Using uninitialised variable 'bar' when this file is included in scope 'source'

(keep in mind that I also use bslint as one of the bsc plugins)

{
    // ...
    "plugins": [
        "@rokucommunity/bslint"
    ]
}

[TwitchBronBron]

I'm pretty sure bslint does not have support for namespace relative function calls at this time.

[ZeeD]

first of all, if you prefer/it's unrelated we can move to another issue, I don't want to pollute.

for this second error keep in mind that it seems still related to the update of bsc: @rokucommunity/bslint@0.7.5 with brighterscript@0.57.2 doesn't show errors.

I don't know if this is useful or only noise, but I also found a strange behavior with bsc @ 0.58:

1. as already said bsc triggers an error
2. also bslint triggers the same error
3. if I remove the bslint plugin from bsconfig.json, then bslint doesn't trigger the error.

In any case, using ns.bar() in foo avoids the error, but I'm not sure if this is intended or not.

[elsassph]

@ZeeD this definitely look like a different issue - could you start a new issue and maybe clarify if there seem to be a regression (something valid which wasn't an error and became an error)

[TwitchBronBron]

The original issue (errors when using variables that were defined within if statements) has been resolved in brighterscript v0.60.2