Validate auto-discovered manifests

[elsassph]

In the absence of bsconfig.json files, the language server will explore all the folders for manifest files.

This is unsafe as the extension may be active while editing non-Roku projects which may also include manifest files.

The discovery mechanism should validate that the manifests "look like" Roku manifests (e.g. "ini" files with maybe a title= entry)

See #1518 where a TODO is added

[TwitchBronBron]

Here's how it could probably work. Whenever find a manifest file, do the following:

• ensure the manifest file is not empty (Roku fails with a totally blank file, but even a single # in the file is valid)
• search a .brs, .bs in the ./source folder or a .brs, .bs, .xml file in the ./components folder next to the manifest.

If those are true, then we have a high degree of certainty that this is a Roku app, because:

• any app without a bsconfig.json must be standard structure
• any app without a .brs/.bs/.xml file has nothing for our language server to validate

[philippe-wm]

It should also generally be a valid .ini file!

[EnTerr]

@elsassph can you show an example of "non-Roku projects which may also include [non-Roku] manifest files"?

Because of my life history, i am cautious of jumping to "an imaginative solution to an imaginary problem" - so first ask to weigh the perceived problem

[TwitchBronBron]

Here's further revisions to this.

It's a roku project if:

• there's a bsconfig.json file
• there's a manifest file that definitely has roku stuff in it (bs_prof, title + major_version + minor_version....etc)
• (there's a non-empty manfiest file) AND (.brs, .bs file in the source/ or .brs, .bs, .xml file components/ folders + possibly validate their contents)

In all of these cases, we can, with a high degree of certainty, know that it's a roku app, and will spin up the lsp for them. If none of the above match, then it's not a Roku app and we should not run the LSP.

Paired with brightscript.languageServer.enableDiscovery (to disable all of this), brightscript.projects (to hand-configure list of projects), bsconfig.json (to register specific folders only), I believe this covers just about everything, and honestly isn't overly difficult to implement.

[EnTerr]

@TwitchBronBron bs_prof is obscure, check should be for any one of these 4:

• title
• major_version
• minor_version
• build_version

and that's it. It is improbable - virtually impossible - to have Roku app without these. Static analyzer insists on them, i believe. title is actually used if device booted w/o network and the versions are what shows when checking * info

Probably something like regex ^\s*(title|major_version|minor_version|build_version)\s*=

• (there's a non-empty manfiest file) AND (.brs, .bs file in the source/ or .brs, .bs, .xml file components/ folders + possibly validate their contents)

Nah, that's not addressing any existing or even speculated problem. Let's not overthink it.