Skip to content

Crash during signature help #1467

@TwitchBronBron

Description

@TwitchBronBron

brighterscript version: 0.69.6

Image

It happens when you are defining a function, and add a comma at the end without having a closing parentheses:

sub test(p1 = invalid, <-- adding this comma causes the crash
  result = 1
end sub

We need to:

  • add unit tests to verify we can reproduce the crash,
  • then fix the issue by:
    • prevent throwing an exception when this happens
    • ideally improve the AST parsing to still produce mostly-valid AST rather than failing the whole parse.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions