Skip to content

bump to Go 1.21, drop Go 1.19, propagate GORACE in testscript#235

Merged
mvdan merged 2 commits intorogpeppe:masterfrom
mvdan:patches
Sep 26, 2023
Merged

bump to Go 1.21, drop Go 1.19, propagate GORACE in testscript#235
mvdan merged 2 commits intorogpeppe:masterfrom
mvdan:patches

Conversation

@mvdan
Copy link
Collaborator

@mvdan mvdan commented Sep 26, 2023

(see commit messages - please do not squash)

And fix up the tests and code to adapt accordingly.
While here, update the checkout action as well.
Do both in a loop to deduplicate code.
While here, only set them if they aren't empty;
this way we don't unnecessarily pollute Vars with entries
such as `GOCOVERDIR=` when they don't do anything useful.
@mvdan mvdan requested a review from myitcv September 26, 2023 10:45
Copy link
Collaborator

@myitcv myitcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvdan mvdan merged commit 32ae337 into rogpeppe:master Sep 26, 2023
@mvdan mvdan deleted the patches branch September 26, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants