testscript: use unix.CloneFile on MacOs #222
Merged
mvdan merged 1 commit intorogpeppe:masterfrom May 5, 2023
Merged
Conversation
bep
force-pushed
the
fix/unexpectedcommandfailuretake4
branch
from
13809f4 to
63bcc78
Compare
bep
changed the title
bep
force-pushed
the
fix/unexpectedcommandfailuretake4
branch
from
63bcc78 to
992d813
Compare
Collaborator
bep
force-pushed
the
fix/unexpectedcommandfailuretake4
branch
from
992d813 to
b96416d
Compare
Contributor
Author
|
@mvdan build should be fixed now (build constrains can be tricky to get right ...) |
bep
force-pushed
the
fix/unexpectedcommandfailuretake4
branch
from
b96416d to
bdcd084
Compare
To fix unexpected errors of type: ``` [signal: killed] FAIL: testscripts/myecho.txt:1: unexpected command failure ``` Fixes rogpeppe#200
bep
force-pushed
the
fix/unexpectedcommandfailuretake4
branch
from
bdcd084 to
4facded
Compare
mvdan
approved these changes
May 5, 2023
Collaborator
mvdan
left a comment
mvdan
left a comment
There was a problem hiding this comment.
SGTM; merging relatively quickly since the issue is relatively severe for Mac users, and the fix being in master will allow for more testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix unexpected errors of type:
Fixes #200