testscript: expose (*TestScript).stdout via Stdout()#216
Merged
Conversation
myitcv
force-pushed
the
expose_testscript_stdout_stderr
branch
from
4ca5004 to
c5cb324
Compare
Collaborator
Author
|
Noting previous exchanges in #140 |
mvdan
approved these changes
Apr 25, 2023
Collaborator
mvdan
left a comment
mvdan
left a comment
There was a problem hiding this comment.
I assume we're OK with Stdout/Stderr not being safe for concurrent use.
myitcv
force-pushed
the
expose_testscript_stdout_stderr
branch
5 times, most recently
from
6d2e77c to
d3aa1fd
Compare
Collaborator
Author
myitcv
force-pushed
the
expose_testscript_stdout_stderr
branch
from
d3aa1fd to
ebf36fa
Compare
Similarly, expose (*TestScript).stderr via Stderr(). Closes #139
myitcv
force-pushed
the
expose_testscript_stdout_stderr
branch
from
ebf36fa to
ca28326
Compare
ldemailly
pushed a commit
to fortio/testscript
that referenced
this pull request
May 7, 2023
Similarly, expose (*TestScript).stderr via Stderr(). Closes rogpeppe#139
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(see commit message)