Conversation
rogpeppe
force-pushed
the
034-fix-continue
branch
from
ab74ad4 to
8d9c165
Compare
This fixes a few issues around the existing `testscript -continue` flag. Notably: - causing `T.Fatal` and `T.FailNow` to return normally meant that some logic inside the testscript package that was expecting the old behaviour would fail to work correctly (for example, a non-existent command would cause a panic) - the logging logic was erroneously assuming that if we got to the end of a script, all sections had passed therefore we could omit the logged messages. We fix the above by making "continue on error" a first class part of `testscript.Params`, so the testscript logic actually knows about it. To test it properly, we need a couple of hacks to make the output predictable. Unfortunately, those hacks are internal only, so it's hard to add similar tests to the `cmd/testscript` command to end-to-end test that, but the existing test should act as sufficient "smoke test" that the continue logic is wired up OK.
rogpeppe
force-pushed
the
034-fix-continue
branch
from
8d9c165 to
0117387
Compare
mvdan
approved these changes
Jan 9, 2023
Collaborator
mvdan
left a comment
mvdan
left a comment
There was a problem hiding this comment.
globals modified by tests always make me worry a bit - I wonder if we could use something other than cmpenv here, like having a glob or regular expression as a placeholder for elapsed times and env var lines.
not super worried about it, though, and this test is certainly better than what I had done before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a few issues around the existing
testscript -continueflag. Notably:T.FatalandT.FailNowto return normally meant that some logic inside the testscript package that was expecting the old behaviour would fail to work correctly (for example, a non-existent command would cause a panic)We fix the above by making "continue on error" a first class part of
testscript.Params, so the testscript logic actually knows about it.To test it properly, we need a couple of hacks to make the output predictable. Unfortunately, those hacks are internal only, so it's hard to add similar tests to the
cmd/testscriptcommand to end-to-end test that, but the existing test should act as sufficient "smoke test" that the continue logic is wired up OK.