Conversation
rogpeppe
force-pushed
the
032-update-lockedfile
branch
from
1d22f4b to
6112e42
Compare
myitcv
approved these changes
Nov 11, 2022
Collaborator
myitcv
left a comment
myitcv
left a comment
There was a problem hiding this comment.
LGTM modulo one suggestion: where the changes in this PR are not mechanical copies from upstream, we should document the differences.
Collaborator
|
Similar nit: assuming you used a tool like gomvpkg, document how you ran it in the commit message :) |
Code taken from upstream commit d7dbe0111ef2a6de80a20fef188db61d8fab5c96. Manual updates: - changed import paths - added `// +build` lines - changed `!unix` build tag in `internal/filelock/filelock_other.go` - removed call to `testenv.MustHaveExec` in `internal/filelock/filelock_test.go`.
rogpeppe
force-pushed
the
032-update-lockedfile
branch
from
6112e42 to
ec08c27
Compare
Owner
Author
|
Updated commit message accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code taken from upstream commit d7dbe0111ef2a6de80a20fef188db61d8fab5c96.
This adds a new function (
Transform).