testscript: add Params.RequireExplicitExec#164
Merged
mvdan merged 1 commit intorogpeppe:masterfrom Jul 6, 2022
Merged
Conversation
mvdan
force-pushed
the
require-explicit-exec
branch
from
c0bda00 to
fdc03d5
Compare
rogpeppe
reviewed
Jul 6, 2022
Owner
rogpeppe
left a comment
rogpeppe
left a comment
There was a problem hiding this comment.
Thanks for doing this! LGTM in general modulo a few comments and suggestions.
We also document how top-level commands fed to RunMain work with and without "exec" the same way, and how RequireExplicitExec can drop backwards compatibility for greater consistency. Fixes rogpeppe#163.
mvdan
force-pushed
the
require-explicit-exec
branch
from
fdc03d5 to
e263e44
Compare
Collaborator
Author
|
@rogpeppe ready for a final approval, I think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(see commit message)
Fixes #163.