testscript: add support for Go master aka 1.18#145
Merged
mvdan merged 1 commit intorogpeppe:masterfrom Sep 23, 2021
Merged
Conversation
mvdan
force-pushed
the
support-1.18
branch
2 times, most recently
from
2c163ac to
6f57cb6
Compare
myitcv
approved these changes
Sep 23, 2021
Collaborator
myitcv
left a comment
myitcv
left a comment
There was a problem hiding this comment.
LGTM although I'll declare I'm not too familiar with the fuzzy stuff
Fuzzing support brought a new parameter to MainStart, as well as more methods on testDeps. Use build tags to support those without breaking 1.16 nor 1.17. While at it, bump CI to test the two latest Go versions, and run 1.17's gofmt, as CI demands it. Finally, make CI also test with Go's master version, to ensure that we are compatible with it. We pin a specific commit, since that keeps CI stable. Fixes rogpeppe#144. Co-authored-by: Roger Peppe <[email protected]>
Collaborator
Author
Collaborator
|
Still LGTM. Thank you for going the extra mile 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(see commit message)