Option to disable loading default configurations files#789
Merged
Conversation
rnelson0
approved these changes
Dec 12, 2017
rnelson0
left a comment
rnelson0
left a comment
Collaborator
There was a problem hiding this comment.
I do not see any obvious unintended side effects from the change itself. As it is a new option that defaults to off, I believe it would be okay to merge as-is and then implement any fixes for unintended side effects as they are observed.
Owner
|
Yeah, I rebased to fix the build failures yesterday and given the scope of the change, I'm happy to make it part of 2.3.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My proposal to issue #787
Fixes #787