Skip to content

Add unit tests for PuppetLint::Checks#743

Merged
rodjek merged 4 commits into
masterfrom
checks_spec
Sep 5, 2017
Merged

Add unit tests for PuppetLint::Checks#743
rodjek merged 4 commits into
masterfrom
checks_spec

Conversation

@rodjek
Copy link
Copy Markdown
Owner

@rodjek rodjek commented Sep 4, 2017

No description provided.

@rnelson0
Copy link
Copy Markdown
Collaborator

rnelson0 commented Sep 4, 2017

It looks okay to me, but I'm not sure I understand the purpose of this change, can you elaborate?

@rodjek
Copy link
Copy Markdown
Owner Author

rodjek commented Sep 5, 2017

The change is adding unit tests for the PuppetLint::Checks class, which is not currently explicitly tested. Some parts of it were implicitly tested by the check plugin tests themselves, but not all of it. Adding tests like this gives visibility to unexpected behaviour changes that might occur as a result of future work.

@rodjek rodjek merged commit a32f983 into master Sep 5, 2017
@rodjek rodjek deleted the checks_spec branch September 5, 2017 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants