Skip to content

Conversation

@SkySkimmer
Copy link
Contributor

@SkySkimmer SkySkimmer commented Sep 5, 2025

@SkySkimmer SkySkimmer added the request: full CI Use this label when you want your next push to trigger a full CI. label Sep 5, 2025
@SkySkimmer SkySkimmer requested review from a team as code owners September 5, 2025 14:42
@coqbot-app coqbot-app bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label Sep 5, 2025
@SkySkimmer SkySkimmer added the request: full CI Use this label when you want your next push to trigger a full CI. label Sep 5, 2025
@coqbot-app coqbot-app bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label Sep 5, 2025
@SkySkimmer SkySkimmer added the request: full CI Use this label when you want your next push to trigger a full CI. label Sep 5, 2025
@coqbot-app coqbot-app bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label Sep 5, 2025
@SkySkimmer SkySkimmer added the needs: overlay This is breaking external developments we track in CI. label Sep 8, 2025
@github-actions github-actions bot added the needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. label Sep 12, 2025
No support yet to actually declare them (entries / high level syntax)

This also fixes printing of mutual records (which used to get printed
as mutual inductives), cf output test diff.
SkySkimmer added a commit to SkySkimmer/MetaRocq that referenced this pull request Sep 15, 2025
SkySkimmer added a commit to SkySkimmer/rocq-lean-import that referenced this pull request Sep 15, 2025
SkySkimmer added a commit to SkySkimmer/coq-elpi that referenced this pull request Sep 15, 2025
SkySkimmer added a commit to SkySkimmer/coq-lsp that referenced this pull request Sep 15, 2025
SkySkimmer added a commit to SkySkimmer/coq-lsp that referenced this pull request Sep 15, 2025
@SkySkimmer SkySkimmer added request: full CI Use this label when you want your next push to trigger a full CI. and removed needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. needs: overlay This is breaking external developments we track in CI. labels Sep 15, 2025
@SkySkimmer SkySkimmer added this to the 9.2+rc1 milestone Sep 15, 2025
@coqbot-app coqbot-app bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label Sep 15, 2025
@SkySkimmer SkySkimmer added kind: internal API, ML documentation... kind: fix This fixes a bug or incorrect documentation. labels Sep 16, 2025
@ppedrot ppedrot self-assigned this Sep 22, 2025
Copy link
Member

@ppedrot ppedrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not completely convinced this is not opening a new venue for soundness bugs, but at least it looks superficially correct.

@ppedrot
Copy link
Member

ppedrot commented Sep 25, 2025

@coqbot merge now

@coqbot-app coqbot-app bot merged commit fab8e5a into rocq-prover:master Sep 25, 2025
7 checks passed
@coqbot-app
Copy link
Contributor

coqbot-app bot commented Sep 25, 2025

@ppedrot: Please take care of the following overlays:

  • 21069-SkySkimmer-mip-mind-record.sh

ppedrot added a commit to MetaRocq/metarocq that referenced this pull request Sep 25, 2025
Adapt to rocq-prover/rocq#21069 (records can be mutual with non records)
@SkySkimmer SkySkimmer deleted the mip-mind-record branch September 25, 2025 14:06
ppedrot added a commit to LPCIC/coq-elpi that referenced this pull request Sep 25, 2025
Adapt to rocq-prover/rocq#21069 (records can be mutual with non records)
ppedrot added a commit to ejgallego/rocq-lsp that referenced this pull request Sep 25, 2025
Adapt to rocq-prover/rocq#21069 (records can be mutual with non records)
SkySkimmer added a commit to rocq-community/rocq-lean-import that referenced this pull request Sep 25, 2025
Adapt to rocq-prover/rocq#21069 (records can be mutual with non records)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind: fix This fixes a bug or incorrect documentation. kind: internal API, ML documentation...

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants