-
Notifications
You must be signed in to change notification settings - Fork 708
Declarations support mixed record/nonrecord inductive blocks #21069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7a0c49f to
8936cf0
Compare
No support yet to actually declare them (entries / high level syntax) This also fixes printing of mutual records (which used to get printed as mutual inductives), cf output test diff.
SkySkimmer
added a commit
to SkySkimmer/MetaRocq
that referenced
this pull request
Sep 15, 2025
SkySkimmer
added a commit
to SkySkimmer/rocq-lean-import
that referenced
this pull request
Sep 15, 2025
SkySkimmer
added a commit
to SkySkimmer/coq-elpi
that referenced
this pull request
Sep 15, 2025
SkySkimmer
added a commit
to SkySkimmer/coq-lsp
that referenced
this pull request
Sep 15, 2025
SkySkimmer
added a commit
to SkySkimmer/coq-lsp
that referenced
this pull request
Sep 15, 2025
8936cf0 to
9a70f8b
Compare
ppedrot
approved these changes
Sep 25, 2025
Member
ppedrot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not completely convinced this is not opening a new venue for soundness bugs, but at least it looks superficially correct.
Member
|
@coqbot merge now |
Contributor
|
@ppedrot: Please take care of the following overlays:
|
ppedrot
added a commit
to MetaRocq/metarocq
that referenced
this pull request
Sep 25, 2025
Adapt to rocq-prover/rocq#21069 (records can be mutual with non records)
ppedrot
added a commit
to LPCIC/coq-elpi
that referenced
this pull request
Sep 25, 2025
Adapt to rocq-prover/rocq#21069 (records can be mutual with non records)
ppedrot
added a commit
to ejgallego/rocq-lsp
that referenced
this pull request
Sep 25, 2025
Adapt to rocq-prover/rocq#21069 (records can be mutual with non records)
SkySkimmer
added a commit
to rocq-community/rocq-lean-import
that referenced
this pull request
Sep 25, 2025
Adapt to rocq-prover/rocq#21069 (records can be mutual with non records)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No support yet to actually declare them (entries / high level syntax)
This also fixes printing of mutual records (which used to get printed as mutual inductives), cf output test diff.
Overlays: